James Cocker
Currently, when you edit the NGINX configuration for a site and click "Save", the edit modal closes. This behaviour makes debugging NGINX config issues difficult, as when you click to Edit the config again, the undo history of the editor is lost, so it's hard to try a change and then undo it, or even undo all changes since you started editing it.
How tricky would it be to save the changes asynchronously, so that the editor can remain open after clicking "Save", thus retaining its undo history?
Dennis
I'm not really sure how hard it would be, I don't think it'll be that hard, but what I'd rather have is something like this;
When you press save, it will save the file and run a nginx -t on your server to test the configs (without reloading or restarting), if a failure occurs, it will tell you that first and then the modal will remain open, of course also displaying the issue that's going on.
James Cocker
Item authorSounds ace! I almost suggested adding the NGINX "test" config feature separately.
However, I'd still find it very useful if the modal stayed open despite passing the tests though, as just because there are no syntax issues, doesn't mean that they changes you made will behave as expected, so it would still be extremely useful to be able to undo recent changes too.
Dennis
@James-Cocker I believe, with the new awesome NGINX editor, this becomes obsolete?
James Cocker
Item authorYep, can confirm the new editor resolves this, thanks!
Keep edit window open when saving NGINX configuration
-
Dennis moved item to board Closed
1 year ago -
Dennis moved item to board Planned
2 years ago -
Dennis moved item to board Under review
2 years ago -
James Cocker moved item to project Site Level Requests
2 years ago -
James Cocker created the item
2 years ago